-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power generation technology
and many subclasses
#1601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the implementation!
Why is the "input" specified in the definition for solar power technlogies
and geothermal power technology
and the other techs not? Can it be left out to be consistent with the other tech definitions?
Generally I understand that the definition part "... that decscribes how to combine... " refers to the axioms - which aim to describe better, how a technology is combined with its energy converting unit
and specifc energy transformation
process. -
However, the definition itself does not explain the HOW. Thus, for an audience that works primarly only with the defintion, the defintion might be confusing?
This might be a little late in the process, but IMO, changing "... that decscribes how to combine... " to "combining" would increase the clarity of the stand-alone definitions.
It would make clear that subclasses of power generation technology
combine "power plant parts" and a "energy transformation process". e.g.:
definition "A power generation technology is an energy technology combining power generating units and energy carriers in a power generation process to generate electrical energy."
definition "A wind power technology is a power generation technology combining wind energy converting units and a wind energy transformation."
definition "A geothermal power technology is a power generation technology combining geothermal power units in an electricity generation process with geothermal energy as input."
definition "A reservoir hydro storage power technology is a power generation technology combining hydro power units in reservoir hydro storage power plants and a hydroelectric energy transformation."
The HOW it is combined in the ontology to other concepts can still be found in the axioms.
Class: OEO_00010423 | ||
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "A power generation technology is an energy technology that describes how to combine power generating units and energy carriers in a power generation process to generate electrical energy.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deviates from the initial proposed definition - : A power generation technology is an energy technology that describes how to combine energy transformation units and energy carriers to generate electricity.
However - I think it adds to the clarity of the definition
Class: OEO_00010426 | ||
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "An offshore wind power technology is a wind power generation technology that describes how to use wind energy converting units in offshore wind farms.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a difference between:
A) ... that describes how to combine ...
B) ... that describes how to use ...
all other techs in the PR use A), only offshore&onshore wind use B)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, B sound more sensible. The "combines" is mentioned in the parent class already and thus holds for the subclasses, too.
The reason is that we classify technologies as plan specifications, i.e. it refers to the description or plan how to do so, not the combination itself.
The use case is to retrieve a hierarchy that contains the all the "technologies" to describe energy scenarios and models, see OpenEnergyPlatform/oekg#43 and #1572 Describing the technologies in detail might exceed the purpose of oeo. However, we might discuss better definitions. |
Co-authored-by: chrwm <[email protected]>
Class: OEO_00010426 | ||
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "An offshore wind power technology is a wind power generation technology that describes how to use wind energy converting units in offshore wind farms.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, B sound more sensible. The "combines" is mentioned in the parent class already and thus holds for the subclasses, too.
I would suggest to leave it as is for now and discuss this in detail in the original issue, which wont be fixed by this PR anyway. |
Co-authored-by: stap-m <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing!
Summary of the discussion
Add
power technology
and subclasses to link power generation units to electricity generation processes.Type of change (CHANGELOG.md)
Add
Workflow checklist
Automation
No automation, part of #1572.
PR-Assignee
term tracker item
Reviewer